928387 - InlineHistory "marked as a duplicate" detection too eager

Status: VERIFIED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: InlineHistory, defect)

Description

[Andre Klapper]

Attachment: InlineScreenshot.png

Upstreaming from https://bugzilla.wikimedia.org/show_bug.cgi?id=55373
We're using bmo4.2's InlineHistory in bugzilla.wikimedia.org (with small CSS adjustments).

Below https://bugzilla.wikimedia.org/show_bug.cgi?id=45051 comment 6, InlineHistory claims that MZMcBride marked bug 43689 as a duplicate of 45051. This is not true; Krinkle did that in comment 5, and MZMcBride only quoted the automatic comment.
History of 43689 also shows that the duplication was not reverted and applied again (to rule out one potential reason).

The only explanation I see is that InlineHistory "marked as a duplicate"
detection is too eager. It should only trigger when that comment is at the end
of the comment, in a separate paragraph.

Could only find bug 759768 which seems to be slightly related.

Comment 1

[:glob ✱]

(In reply to Andre Klapper from comment #0)
> The only explanation I see is that InlineHistory "marked as a duplicate"
> detection is too eager. It should only trigger when that comment is at the
> end of the comment, in a separate paragraph.

it's a shame we have to look at the comment text just to support the older duplicate comments (filed bug 928786 to track migrating them).

Comment 2

[:glob ✱]

Attachment: 928387_1.patch

while looking over the code and playing around, i realised there's a large cost to searching the comment text for comment created prior to bugzilla 3.0.

this change drops support for showing those comments inline (they will still be listed in the "duplicates" field).

andre and dkl, what are your thoughts on doing this?

Comment 3

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #2)
> andre and dkl, what are your thoughts on doing this?

You know me. Whatever it takes to optimize page load time :) But seriously I would imagine that people are most interested in more recent dupes and will not miss anything inline that happened prior to the days of 3.0.

Dkl

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 819545 [details] [diff] [review]
928387_1.patch

Review of attachment 819545 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/InlineHistory/Extension.pm
Committed revision 9091.